Skip to content

Proxy support #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Proxy support #23

wants to merge 1 commit into from

Conversation

pete-otaqui
Copy link

Hi there,

I've added support for the http_proxy / HTTP_PROXY environment variable. Currently only tested on my mac.

I think that ideally using the environment variable or not should be an option to the constructor. Maybe something like:

@browser = Selenium::Client::Driver.new( :http_proxy => true ) # use environment variable
@browser = Selenium::Client::Driver.new( :http_proxy => 'http://user:pass@proxy:port' ) # use this proxy
@browser = Selenium::Client::Driver.new( :http_proxy => false ) # no proxy (the default)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@pete-otaqui